Fix #288, Remove unnecessary CF_UnionArgs_Payload_t union #398
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| ret = fn(cmd->data.byte[0], context); | ||
| ret = fn(cmd->byte[0], context); |
Check notice
Code scanning / CodeQL
Use of non-constant function pointer
|
@thnkslprpt I reverted the original (#341) so we could move it to the next release. Does everything look good here? |
@dzbaker I'm unsure of the effects of this PR as it includes a few other merged commits on top of the original commit removing the It's quite a simple change - maybe easier if I submit a new PR just going from the current main branch with just the removal of |
@thnkslprpt Yes, thank you, it may be best to submit a new PR and I can close this one. |
Cool no worries. |
|
Replaced by #400. |
Checklist
Describe the contribution
Fixes #288
CF_UnionArgs_Payload_thas been removed, given that only a single member of the 3 is used in CF. That member variable -byte- has been moved into theCF_UnionArgsCmd_tstruct, which was the only place whereCF_UnionArgs_Payload_twas used.Re-introduced from #341. #393, #395 reverted this PR.
Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes
No impact on logic.
Contributor Info
@thnkslprpt